Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example: results tracker #351

Merged
merged 7 commits into from
Apr 15, 2023
Merged

Conversation

harningle
Copy link
Contributor

Add a heatmap of points scored for each driver in each race, following #325.

Xuanyi Wang and others added 6 commits April 12, 2023 01:00
@theOehrly
Copy link
Owner

This looks good, and the documentation build mostly works as expected. (If you want to take a look at it, you can download the doc build as an artifact from the test runs.)

The only minor problem is, that no thumbnail is generated for the gallery.
grafik

In theory, static thumbnails can be generated (https://sphinx-gallery.github.io/stable/auto_plotly_examples/plot_0_plotly.html#sphx-glr-auto-plotly-examples-plot-0-plotly-py). I just gave it a try, but I couldn't get it to work.

If you feel like spending some more time on this to try and figure out how to get thumbnail generation working, feel free to do so. Else, I'm happy to merge this as it is. I don't want to spend too much time on this, for a relatively minor visual problem.

@harningle
Copy link
Contributor Author

harningle commented Apr 14, 2023

Yes I noticed the same issue when I built the doc locally. Found a solution here: smarie/mkdocs-gallery#49 (comment). Basically we add kaleido to requirements-dev.txt for getting the png thumbnails, and add plotly.io._sg_scraper.plotly_sg_scraper to image_scrapers in docs/conf.py. I added a commit for this.

@theOehrly
Copy link
Owner

Awesome, looks perfect now. Thank you for adding this!

@theOehrly theOehrly merged commit 3f4f262 into theOehrly:master Apr 15, 2023
@harningle harningle deleted the results-tracker branch May 18, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants